use aspect manifest to determine which dependencies are aspects instead importing and loading them #8738
+30
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad importing and loading them
GiladShoham
reviewed
Apr 4, 2024
|
|
||
| const { manifests } = await this.loadAspectDefsByOrder(aspectsDefs, [component.id.toString()], true, true); | ||
| const manifest = manifests[0]; | ||
| const runtimeDeps = manifest.getRuntime(MainRuntime)?.dependencies?.map((dep) => dep.id); |
There was a problem hiding this comment.
why do you assume it's the main runtime here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we load (and import if not exist) each one of the aspect dependencies in order to check if it's an aspect.
To improve the performance and to not bring unnecessary components, this PR finds and reads the manifest to see which dependencies were injected.